Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grid] Fix rounding errors #12952

Merged

Conversation

RobertPurcea
Copy link
Contributor

Use 7 significant numbers instead of 6 for better rounding accuracy when calculating grid sizes

Closes #12353

@oliviertassinari oliviertassinari added new feature New feature or request component: Grid The React component. labels Sep 21, 2018
@oliviertassinari oliviertassinari merged commit 5045d15 into mui:master Sep 21, 2018
@oliviertassinari
Copy link
Member

@RobertPurcea It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

marcelpanse pushed a commit to marcelpanse/material-ui that referenced this pull request Oct 2, 2018
* use 7 significant numbers when calculating grid sizes for better accuracy

* Add comment back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Grid The React component. new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants